Adds forceNode flag. #469
Closed
Adds forceNode flag. #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wser based implementations.
Added carrying over of forceNode to transport.
|
@Eusebius1920 could you please resolve conflicts? |
|
@darrachequesne, I resolved the conflicts, but give me a few days to check if everything is working as expected. I had no time for that yet... |
|
I resolved the conflicts again. Still working a treat. Thanks for your patience @darrachequesne ! |
darrachequesne
pushed a commit
that referenced
this pull request
Oct 30, 2016
…fering Browser based implementations. (#469)
|
Merged here: 8be5864. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #461, I created a pull request with an (optional) flag that changes the preference of native Websockets over the nodejs implementation.
To ensure compatibility the default behavior - by setting forceNode to false or by not setting it at all - does not change.
I just adjusted it for the websocket-transport as the others already have the correct behavior. (Should this be mentioned in the documentation?)