Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad package reference causes error on upstream builds #639

Closed
jasonkenneth opened this issue Jan 26, 2022 · 1 comment
Closed

Bad package reference causes error on upstream builds #639

jasonkenneth opened this issue Jan 26, 2022 · 1 comment

Comments

@jasonkenneth
Copy link

We're keeping our dependencies up to date on an Angular 12 / nestjs / nrwl monorepo application. When I upgraded to the latest versions of socket.io, I get a build error from within node_modules.

Error: node_modules/engine.io/build/transport.d.ts:4:10 - error TS2305: Module '"engine.io-parser"' has no exported member 'Packet'.

4 import { Packet } from "engine.io-parser";
           ~~~~~~

It turns out it's because the vLatest of engine.io actually requires at least engine.io-parser v5.0.3, but the reference only pulls ~5.0.0. If I install engine.io-parser directly in my app to 5.0.3, the build error disappears.

"engine.io-parser": "~5.0.0",

darrachequesne added a commit that referenced this issue Feb 23, 2022
In order to make sure the types added in [1] are included.

Related:

- #639
- #640

[1]: socketio/engine.io-parser@ad5bd7d
@darrachequesne
Copy link
Member

This should be fixed by 1bc5b1a, included in engine.io@6.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants