You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Recently engine.io got whole new typescript code, but there are places that need for fixes.
One of it is private field id in Socket class. Getting and id of Socket is one of core mechanism that people use in theirs projects. Now there is no way for getting an id of Socket due to it's private accessor.
Engine.IO server version: 6.2.0
Solution id field in Socket class is set to be readonly so it should be 100% safe to switch it from being private to being public.
Other way for fixing it can be for example adding public getter method to Socket class.
The text was updated successfully, but these errors were encountered:
Describe the bug
Recently engine.io got whole new typescript code, but there are places that need for fixes.
One of it is private field
id
inSocket
class. Getting andid
ofSocket
is one of core mechanism that people use in theirs projects. Now there is no way for getting anid
ofSocket
due to it's private accessor.Engine.IO server version:
6.2.0
Solution
id
field inSocket
class is set to be readonly so it should be 100% safe to switch it from being private to being public.Other way for fixing it can be for example adding public getter method to
Socket
class.The text was updated successfully, but these errors were encountered: