Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js versions below 10.2 are not compatible with the latest version 6.5.1. #686

Closed
guohaoyun opened this issue Jul 6, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@guohaoyun
Copy link

In version 6.4.1, in the 'onPacket' method of 'engine.io/build/socket.js', the 'pong' event does not execute 'this.pingIntervalTimer.refresh()', while in the latest version 6.5.1, it does execute. The 'refresh' method was introduced in Node.js v10.2, so it throws an exception when executed in lower versions, resulting in 'this.pingIntervalTimer.refresh() is not a function' error and causing the service to crash. Please document this situation to prevent errors for users using lower versions of Node.js.

@guohaoyun guohaoyun added the bug Something isn't working label Jul 6, 2023
darrachequesne added a commit that referenced this issue Jul 9, 2023
The server uses `timeout.refresh()` (see [1]), which was added in Node.js 10.2.0.

Reference: https://nodejs.org/api/timers.html#timeoutrefresh

Related: #686

[1]: 37474c7
darrachequesne added a commit to socketio/socket.io that referenced this issue Jul 9, 2023
The Engine.IO server uses `timeout.refresh()` (see [1]), which was
added in Node.js 10.2.0.

Reference: https://nodejs.org/api/timers.html#timeoutrefresh

Related: socketio/engine.io#686

[1]: socketio/engine.io@37474c7
@darrachequesne
Copy link
Member

Hi! I have updated the range of supported versions: 7dd1350

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants