clear writeBuffer in each drain + clear writeBuffer after nextTick
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new test for clean writeBuffer in nextTick.
| var engine = listen({ allowUpgrades: false }, function (port) { | ||
| // hack to access the sockets created by node-xmlhttprequest |
There was a problem hiding this comment.
Why did you undo this test?
There was a problem hiding this comment.
This change was needed when we upgraded node-xmlhttprequest to 1.5.0
There was a problem hiding this comment.
Sorry. I think I have some conflicts in my github repository, let me check it again.
|
Ok, conflicts resolved. Please check them again. |
| @@ -24,6 +24,7 @@ function Socket (id, server, transport) { | |||
| this.readyState = 'opening'; | |||
| this.writeBuffer = []; | |||
| this.packetsFn = []; | |||
| this.packetLengths = []; | |||
There was a problem hiding this comment.
In order to keep packets length
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
close also if socket.readyState is on "opening"
darrachequesne
added a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains new changes for issue #89 and issue #59.