Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#99 packet event #113

Merged
merged 1 commit into from Nov 5, 2012
Merged

#99 packet event #113

merged 1 commit into from Nov 5, 2012

Conversation

Jxck
Copy link
Contributor

@Jxck Jxck commented Nov 5, 2012

Added packet event to socket.

but I need more detail about packetCreate for implement.

@rauchg
Copy link
Contributor

rauchg commented Nov 5, 2012

Perfect, thanks @Jxck

rauchg added a commit that referenced this pull request Nov 5, 2012
@rauchg rauchg merged commit 95f0614 into socketio:master Nov 5, 2012
@rauchg
Copy link
Contributor

rauchg commented Nov 5, 2012

https://github.com/LearnBoost/engine.io/blob/master/lib/socket.js#L275

packetCreate would be emitted with the object passed to writeBuffer there.
Essentially:

var packet = { type: type, data: data };
this.emit('packetCreate', packet);

This would allow 3rd parties to modify / examine outgoing packets

@Jxck
Copy link
Contributor Author

Jxck commented Nov 5, 2012

ah, I see.

darrachequesne pushed a commit that referenced this pull request May 8, 2020
Added the URL where the flash files can be found in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants