Refresh ping timers #628
Merged
Refresh ping timers #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/socket.ts
Outdated
| this.pingIntervalTimer = setTimeout(() => { | ||
| debug( | ||
| "writing ping packet - expecting pong within %sms", | ||
| this.server.opts.pingTimeout | ||
| ); | ||
| this.sendPacket("ping"); | ||
| this.resetPingTimeout(this.server.opts.pingTimeout); |
There was a problem hiding this comment.
The behavior is changed here, isn't it? The client would now have up to pingTimeout + pingInterval ms to respond to the ping, instead of pingTimeout ms in the current impl.
Nibbler999
force-pushed
the
timer-refresh
branch
from
a46ebb8
to
ef4b018
Compare
|
I'll limit the scope to just |
|
@Nibbler999 thanks a lot 👍 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Ping timers are repeatedly cleared and recreated
New behaviour
Ping timers are refreshed instead which is more efficient
Other information (e.g. related issues)
https://nodejs.org/docs/latest-v10.x/api/timers.html#timers_timeout_refresh