Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move types dependencies to devDependencies #635

Closed
wants to merge 1 commit into from

Conversation

jougene
Copy link

@jougene jougene commented Jan 10, 2022

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

New behaviour

Other information (e.g. related issues)

@darrachequesne
Copy link
Member

Hi! Thanks for opening this.

The types dependencies were initially set as devDependencies, but we then decided to move them to dependencies, to make it easier for TypeScript users to consume the module. You can find the discussion here: socketio/socket.io#3690

See also: socketio/socket.io@118cc68

@jougene
Copy link
Author

jougene commented Jan 12, 2022

Oh, thanks for clarifying this.

@jougene jougene closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants