Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clientsCount public #675

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

tyilo
Copy link
Contributor

@tyilo tyilo commented Apr 19, 2023

Fixes #672

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

clientsCount is private which it shouldn't be as it is explicitly mentioned as something you can use in both the README:

- `clientsCount` _(Number)_: number of connected clients.

and the website: https://socket.io/docs/v4/server-instance/#serverengine

New behaviour

clientsCount is public.

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit bd6d471 into socketio:main Apr 19, 2023
@darrachequesne
Copy link
Member

Thanks!

@tyilo tyilo deleted the public-clients-count branch April 20, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clientsCount property of server... why need to keep this private,
2 participants