Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server's certificate is not verified on TLS mode #34

Open
jianjunz opened this issue Jul 8, 2015 · 6 comments
Open

Server's certificate is not verified on TLS mode #34

jianjunz opened this issue Jul 8, 2015 · 6 comments

Comments

@jianjunz
Copy link
Contributor

jianjunz commented Jul 8, 2015

The Socket.IO cpp client doesn't verify server's certificate while TLS is enabled. So the server's certificate may be issued by an untrusted authority or server's domain may not match certificate's CN/SAN.

@melode11
Copy link
Contributor

melode11 commented Jul 9, 2015

Hi, I'll seek a patch for that. Maybe a callback to ask whether trust the certificate.

@jianjunz
Copy link
Contributor Author

Seems that you're busy these days :)

I found ssl::context::set_verify_mode is what we need. I'll submit a patch to fix it.

@jianjunz
Copy link
Contributor Author

#41 has been submitted for this issue.

@jmigual
Copy link
Collaborator

jmigual commented Feb 25, 2022

Hi, is this issue still there?

@jianjunz
Copy link
Contributor Author

I think the issue is still there. The comment above suggested to have a callback for certificate verification.

@wuendi
Copy link

wuendi commented Dec 7, 2023

Could someone provide a callback example for certificate verification? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants