Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into development
Browse files Browse the repository at this point in the history
* origin/master:
  Fix Starscream to version 4.0.4
  Remove unused var in SocketAckManagerTest.testManagerTimeoutAck
  • Loading branch information
nuclearace committed Aug 25, 2023
2 parents 0898078 + d7846b3 commit 2058eba
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ let package = Package(
.library(name: "SocketIO", targets: ["SocketIO"])
],
dependencies: [
.package(url: "https://github.com/daltoniam/Starscream", .upToNextMinor(from: "4.0.0")),
.package(url: "https://github.com/daltoniam/Starscream", .exactItem("4.0.4")),
],
targets: [
.target(name: "SocketIO", dependencies: ["Starscream"]),
Expand Down
1 change: 0 additions & 1 deletion Tests/TestSocketIO/SocketAckManagerTest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ class SocketAckManagerTest : XCTestCase {

func testManagerTimeoutAck() {
let callbackExpection = expectation(description: "Manager should timeout ack with noAck status")
let itemsArray = ["Hi", "ho"]

func callback(_ items: [Any]) {
XCTAssertEqual(items.count, 1, "Timed out ack should have one value")
Expand Down

0 comments on commit 2058eba

Please sign in to comment.