Allow . to match any character, including line separators.

[hanishabsigh]

First...thank you for this library. I was experiencing an issue in which a large incoming event wasn't being passed to the appropriate on: handler. No error was thrown. After some investigation, I narrowed it down to regex operations that weren't outputting valid json, thus leading the NSJSONSerialization to fail. Here is an example of the regex, although it happens a few times within the library:

var mutMessage = RegexMutable(stringMessage)
let messageGroups = mutMessage["(\\d*)\\/?(\\w*)?,?(\\d*)?(\\[.*\\])?"].groups()

The end of the regex uses a . to match any character, but by default it does not match line separators. If the intent is to include them, SwiftRegex lets us set the option NSRegularExpressionOptions.DotMatchesLineSeparators. I attempted a pull request to do the following but it wasn't working for me:

var mutMessage = RegexMutable(stringMessage)
let messageGroups = mutMessage["(\\d*)\\/?(\\w*)?,?(\\d*)?(\\[.*\\])?",NSRegularExpressionOptions.DotMatchesLineSeparators].groups()

I must be missing something, I thought that subscript would work but it crashes for me. The following did work:

var mutMessage = RegexMutable(stringMessage)
var swiftRegex = SwiftRegex(target: mutMessage, pattern: "(\\d*)\\/?(\\w*)?,?(\\d*)?(.*)?", options: NSRegularExpressionOptions.DotMatchesLineSeparators);
let messageGroups = swiftRegex.groups()

Also, it could be helpful to include a warning when the event parsing fails. Thanks!

[nuclearace]

@hanishabsigh can you provide a message that fails to get parsed. You can uncomment https://github.com/socketio/socket.io-client-swift/blob/master/SwiftIO/SocketEngine.swift#L409 to see messages before they get sent to the socket.io-client parser.

[nuclearace]

I'm actually finding a few problems with regex. Mostly due to the differences between NSString and String.

[hanishabsigh]

My object that fails is very large, here is an example I was able to track down:

The following fails:

"42[\"auto\",{\"message_of_the_date\":\"line one\nline two\"}]"

The following succeeds:

"42[\"auto\",{\"message_of_the_date\":\"line one line two\"}]"

The line break in the message of the day causes the parsing of the groups to break.

[hanishabsigh]

@nuclearace I just noticed you made some parsing changes, this was tested prior to those changes, thanks

[nuclearace]

@hanishabsigh It seems to work for me on the latest. Please note #13 though. Since it can cause the regex to fail sometimes. Which is why I changed some things.

[hanishabsigh]

@nuclearace This still isn't working for me, incoming messages can't even get passed the following line:

socket.io-client-swift/SwiftIO/SocketParser.swift

Line 224 in e932d0a

let messageGroups = stringMessage["(\\d*)\\/?(\\w*)?,?(\\d*)?\\[\"(.*?)\",?(.*?)?\\]$"].groups()

Replacing line 224 with the following worked:

let messageGroups = stringMessage["(\\d*)\\/?(\\w*)?,?(\\d*)?\\[\"(.*?)\",?(.*?)?\\]$", NSRegularExpressionOptions.DotMatchesLineSeparators].groups()

[nuclearace]

@hanishabsigh try after 44e2781

[hanishabsigh]

@nuclearace Checking against the latest commit isn't working, something about the changes in SwiftRegex. So far from what I can tell regex.firstMatchInString in the groups method isn't returning anything. Still investigating. Thanks

[nuclearace]

This client is able to get this for me:

socket.emit("jsonTest", {foo: "string\ntest test"})

[hanishabsigh]

Ok, fixed it by changing the following:

final var targetRange: NSRange {
    return NSRange(location: 0,length: countElements(target))
}

To this:

final var targetRange: NSRange {
    return NSRange(location: 0,length: target.utf16Count)
}

I think the error I was experiencing was happening because my json had variable-width Unicode characters. Found someone having the same issues with swift on StackOverflow: http://stackoverflow.com/questions/25882503/how-can-i-use-nsregularexpression-on-swift-strings-with-variable-width-unicode-c

[nuclearace]

@hanishabsigh so does c67e7a3 fix it

[hanishabsigh]

@nuclearace Yes, that commit fixes it, thanks.