Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconnectAttempts config ignored #989

Closed
yevreinov opened this issue Mar 28, 2018 · 1 comment
Closed

reconnectAttempts config ignored #989

yevreinov opened this issue Mar 28, 2018 · 1 comment
Assignees

Comments

@yevreinov
Copy link

I'm working with version 13.1.1
Initializing manager like this:

let socketManager = SocketManager(socketURL: URL(string: connectString)!, config: [ .log(true), .compress, .reconnects(true), .reconnectWait(3), .reconnectAttempts(10), .forceNew(true) ])

reconnectAttempts is ignored, it is always -1 (keeps reconnecting always).

I believe this is caused by setConfigs method in SocketManager.swift - it is missing reconnectAttempts case completely.

@nuclearace
Copy link
Member

🤦‍♂️

@nuclearace nuclearace self-assigned this Mar 30, 2018
@nuclearace nuclearace added the bug label Mar 30, 2018
@nuclearace nuclearace mentioned this issue Mar 30, 2018
nuclearace added a commit that referenced this issue Mar 30, 2018
* development:
  bump version
  Set reconnectAttempts in manager. Fixes #989
nuclearace added a commit that referenced this issue May 16, 2018
* development:
  Add note about manager not being thread safe
  Make it clear that `handleQueue` should be serial
  remove some redundant connected checking
  get rid of internal emitAck method
  open engine
  Add raw view to ack emitter
  change access level to public for raw view
  rename SocketBinaryView
  Add rawEmitView. Implements #992
  Add way to skip binary inspection.
  bump version
  Set reconnectAttempts in manager. Fixes #989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants