Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

update xmlhttprequest dependency #512

Closed
wants to merge 1 commit into from

4 participants

@jfromaniello

I really wish you could bump to xmlhttprequest version. 1.5.0 has a setDisableHeaderCheck` that allows me to pass a cookie in there.. This allows me to monkeypatch xmlhttprequest to use the cookie I want so I can authenticate my client as shown in this gist:

https://gist.github.com/4087861

thank you very much

@marcelfalliere

guyz,
I know it's late and out of subject, but I can't seem to find any doc on �setDisableHeaderCheck. It's not on w3c xmlhttprequest spec page, google finds only two pages of gist and stuff like that. Would you be kind enough to point me in a direction ?
Sorry to bother this thread.

@jfromaniello

@marcelfalliere xmlhttprequest is a node.js module that mimics the behavior and interface of the Browser's XmlHttpRequest. You can't disable the header check process on the browser, this is a mechanism that prevents user changing some headers like cookie header.

@gkorland

Is this pull request still relevant?

@rauchg
Owner

Nope. Should be good on master

@rauchg rauchg closed this
@gkorland gkorland referenced this pull request in jfromaniello/passport.socketio
Closed

move to the official version of socket.io-client #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  package.json
View
2  package.json
@@ -20,7 +20,7 @@
, "dependencies": {
"uglify-js": "1.2.5"
, "ws": "0.4.x"
- , "xmlhttprequest": "1.4.2"
+ , "xmlhttprequest": "1.5.0"
, "active-x-obfuscator": "0.0.1"
}
, "devDependencies": {
Something went wrong with that request. Please try again.