Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a local flag that can prevent the adapter from publishing the emi… #119

Closed
wants to merge 2 commits into from

Conversation

tal-beja
Copy link

…t to the server

@tal-beja
Copy link
Author

Works with this pull request:
socketio/socket.io#2628

@darrachequesne
Copy link
Member

@tal-beja hi! May I ask what your use case is please?

@tal-beja
Copy link
Author

tal-beja commented Aug 4, 2016

When several insrances of a server recieve the same even from a third party (not from a client), each server instance broadcast the event to all his clients.
If I use the redis adapter each server publish to redis about the event and thus each client recieve the same event times the number of the server instances.
With the local flag, and the change in the redis adapter, each server instance send the event only to his client, so each client recieve only one uniqe event.

@darrachequesne
Copy link
Member

@tal-beja sorry for the delay. Could you please rebase and add some tests please?

Also, is the redis version bump mandatory for this to work? Do you know what the impact is? (the changelog seems huge, especially towards the pub/sub mechanism)

@KristjanTammekivi
Copy link

bump

@17289kjhajshd389210h
Copy link

+1 @tal-beja

darrachequesne pushed a commit that referenced this pull request Nov 27, 2016
That new flag will prevent the adapter (redis) from publishing the emit
to the pub/sub server.
@darrachequesne
Copy link
Member

Merged as c38e323. Thanks!

@darrachequesne darrachequesne added this to the 2.0.0 milestone Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants