Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup imports and use exported type and enum from socket.io-adapter #16

Merged
merged 4 commits into from
Feb 27, 2024
Merged

chore: cleanup imports and use exported type and enum from socket.io-adapter #16

merged 4 commits into from
Feb 27, 2024

Conversation

jwetzell
Copy link
Contributor

  • split type and other imports to be consistent with other adapter repos
  • use the MessageType enum instead of just hardcoded numbers

@darrachequesne darrachequesne merged commit a950764 into socketio:main Feb 27, 2024
2 checks passed
@darrachequesne
Copy link
Member

Awesome, thanks 👍

darrachequesne pushed a commit that referenced this pull request Feb 27, 2024
@jwetzell @darrachequesne
refactor: use exported type and enum from socket.io-adapter (#16)
c438796
@jwetzell jwetzell deleted the chore/cleanup branch February 27, 2024 23:12
@jwetzell
Copy link
Contributor Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwetzell @darrachequesne