Emit returns a weird type so union types no longer compile #3844

solomon23 · 2021-03-17T18:10:00Z

Describe the bug
this used to compile in typescript but won't in 4.0

(channel ? io.to(channel) : io).emit("stuff", message);

#3843

The text was updated successfully, but these errors were encountered:

``` (channel ? io.to(channel) : io).emit("stuff", message); ``` would no longer compile. Related: #3844

darrachequesne · 2021-03-18T10:39:34Z

This should be fixed by 1a72ae4. Thanks.

``` (channel ? io.to(channel) : io).emit("stuff", message); ``` would no longer compile. Related: socketio#3844

solomon23 added the bug Something isn't working label Mar 17, 2021

darrachequesne pushed a commit that referenced this issue Mar 18, 2021

fix(typings): update return type from emit (#3843)

1a72ae4

``` (channel ? io.to(channel) : io).emit("stuff", message); ``` would no longer compile. Related: #3844

darrachequesne closed this as completed Mar 18, 2021

darrachequesne added this to the 4.0.1 milestone Mar 31, 2021

dzad pushed a commit to dzad/socket.io that referenced this issue May 29, 2023

fix(typings): update return type from emit (socketio#3843)

097ccb8

``` (channel ? io.to(channel) : io).emit("stuff", message); ``` would no longer compile. Related: socketio#3844

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit returns a weird type so union types no longer compile #3844

Emit returns a weird type so union types no longer compile #3844

solomon23 commented Mar 17, 2021 •

edited

Loading

darrachequesne commented Mar 18, 2021

Emit returns a weird type so union types no longer compile #3844

Emit returns a weird type so union types no longer compile #3844

Comments

solomon23 commented Mar 17, 2021 • edited Loading

darrachequesne commented Mar 18, 2021

solomon23 commented Mar 17, 2021 •

edited

Loading