Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 413 when request payload is bigger than maxHttpBufferSize. #4293

Closed
maxfliri opened this issue Feb 25, 2022 · 1 comment
Closed

Return 413 when request payload is bigger than maxHttpBufferSize. #4293

maxfliri opened this issue Feb 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@maxfliri
Copy link

With polling transport, if the client sends a request with a payload bigger than maxHttpBufferSize, the server returns a response with status 502 Bad Gateway. It should instead return 413 Payload Too Large.
@maxfliri maxfliri added the to triage Waiting to be triaged by a member of the team label Feb 25, 2022
darrachequesne added a commit to socketio/engine.io that referenced this issue Feb 28, 2022
@darrachequesne
refactor: return an HTTP 413 response for too large payloads
e24b27b 
Before this, the connection was closed abrutly with an HTTP 502
response.

See also: f8100f9

Related: socketio/socket.io#4293
@darrachequesne
Copy link
Member

You are absolutely right! I have updated the HTTP status: socketio/engine.io@e24b27b

@darrachequesne darrachequesne added enhancement New feature or request and removed to triage Waiting to be triaged by a member of the team labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxfliri @darrachequesne