Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hybi-17 Unsupported #585

Closed
giggsey opened this issue Oct 19, 2011 · 5 comments
Closed

hybi-17 Unsupported #585

giggsey opened this issue Oct 19, 2011 · 5 comments
Labels
bug Something isn't working

Comments

@giggsey
Copy link

giggsey commented Oct 19, 2011

This just got pushed to Chrome Dev (16.0.912.0), and it appears to be using hybi-17.

Details: http://trac.webkit.org/changeset/97249

My socket.io still connects, is just falls back to another method.
@3rd-Eden
Copy link
Contributor

Ping @einaros

@einaros
Copy link
Contributor

einaros commented Oct 19, 2011

HyBi-16 to HyBi-17 has no breaking changes. Should work just fine with the current socket.io version.

@giggsey
Copy link
Author

giggsey commented Oct 19, 2011

Good point, I was on 0.8.4.

@giggsey giggsey closed this as completed Oct 19, 2011
@3rd-Eden
Copy link
Contributor

@einaros not even the Sec-WebSocket-Origin header? As we should be using that to check against the manager.get('origin') ?

@einaros
Copy link
Contributor

einaros commented Oct 19, 2011

@3rd-Eden, I've updated that as well.

@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
This was referenced May 26, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
darrachequesne added a commit that referenced this issue Jul 8, 2024
@darrachequesne
[chore] Bump xmlhttprequest-ssl to version 1.5.4 (#585)
8ce2432
darrachequesne pushed a commit that referenced this issue Jul 8, 2024
@oliversalzburg @darrachequesne
[fix] Deprecated Buffer usage in dependency (#585)
ad844f4 
The `Buffer` constructor has been deprecated in favor of safer alternatives.
See https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/

This was fixed in base64id@2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@3rd-Eden @giggsey @einaros