Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic cors #1777

Merged
merged 3 commits into from Sep 22, 2014
Merged

Dynamic cors #1777

merged 3 commits into from Sep 22, 2014

Conversation

akamensky
Copy link
Contributor

Implementing 2nd method from issue #1772

Why is it needed: To dynamically check whether origin is allowed to access, when hard-coded origins are not an option (for example based on values in database that dynamically change).

@rase-
Copy link
Contributor

rase- commented Sep 22, 2014

Awesome! Thanks a ton @akamensky!

rase- added a commit that referenced this pull request Sep 22, 2014
@rase- rase- merged commit 1b4f6a5 into socketio:master Sep 22, 2014
@akamensky akamensky deleted the dynamic-cors branch September 23, 2014 02:03
@akamensky
Copy link
Contributor Author

@rase- Is it know when this will be released? I sort of need to use it in my project :D

@rase-
Copy link
Contributor

rase- commented Sep 23, 2014

@akamensky we're planning a release this week. Until then, if you want to use it right away, you can reference the current master in your package.json by commit and update it to the latest version after release.

@akamensky
Copy link
Contributor Author

Thanks!

On Tue, Sep 23, 2014 at 10:41 PM, Tony Kovanen notifications@github.com
wrote:

@akamensky https://github.com/akamensky we're planning a release this
week. Until then, if you want to use it right away, you can reference the
current master in your package.json by commit and update it to the latest
version after release.


Reply to this email directly or view it on GitHub
#1777 (comment).

Best regards,
Alexey Kamenskiy
me@akamensky.com
http://akamensky.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants