Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating Open Collective #2933

Closed
wants to merge 2 commits into from
Closed

Activating Open Collective #2933

wants to merge 2 commits into from

Conversation

xdamman
Copy link
Contributor

@xdamman xdamman commented May 8, 2017

Please merge this pull request to activate your Open Collective https://opencollective.com/socketio

@darrachequesne
Copy link
Member

Merged as 0d07c47.

I'm not really fond of the postinstall script, so I excluded it from the merge. Is it something mandatory?

@xdamman
Copy link
Contributor Author

xdamman commented May 8, 2017

It's not but it's a nice touch to ask for donations. Have you tried it? You can also pass it the --plain option to make it text only (and more subtle)

@darrachequesne
Copy link
Member

@xdamman I am still not convinced that adding another dependency (something like 49 Mo if I'm not mistaken) is really necessary here. Besides, what will happen if webpack and babel and mocha and gulp... all add that postinstall script?

@xdamman
Copy link
Contributor Author

xdamman commented May 9, 2017

I see 22MB on my machine. But that's highly variable depending on what other modules you already have installed in your project.

If other projects also have it, npm is smart enough to only install it once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants