Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about default origins value. Update API.md #3464

Merged
merged 1 commit into from Sep 20, 2019

Conversation

JonaMX
Copy link
Contributor

@JonaMX JonaMX commented Jul 4, 2019

I was struggling with CORS issues using explicitly the default origins value * on development, a value that is retrieved from a .env file, but turns out that the default is actually *:*.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current documentation

origins (String): the allowed origins (*)

New documentation

origins (String): the allowed origins (*:*)

Other information (e.g. related issues)

Fix documentation about default origins value. The default should read `*:*` instead of `*
@darrachequesne darrachequesne merged commit 8227192 into socketio:master Sep 20, 2019
1 check passed
@darrachequesne
Copy link
Member

darrachequesne commented Sep 20, 2019

@JonaMX thanks!

@darrachequesne darrachequesne added this to the 2.3.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants