fix: add types to exports field to be compatible with nodenext module resolution #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See microsoft/TypeScript#46770 (comment) for detail, in `nodenext` module resolution we need to specify `types` inside `exports` field.
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
…le resolution (socketio#4228) See [1] for detail, in `nodenext` module resolution it requires a `types` field in `exports` with full filename including extension. [1]: microsoft/TypeScript#46770 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Using
typescript@4.6.0-dev.20211225and"moduleResolution": "nodenext"we are unable to resolve types ofsocket.ioNew behaviour
Make TypeScript successfully resolve types
Other information (e.g. related issues)
See microsoft/TypeScript#46770 (comment) for detail, in
nodenextmodule resolution it requires atypesfield inexportswith full filename including extension