Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] BroadcastWithAck behavior #4878

Merged
merged 7 commits into from
Jan 2, 2024
Merged

[FIX] BroadcastWithAck behavior #4878

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0eba2b4
* fixed wrong handeling of expectSingleResponse in broadcast-operator.ts
BCCSTeam Nov 20, 2023
5ddac18
* fixed wrong handeling of expectSingleResponse in broadcast-operator.ts
BCCSTeam Nov 25, 2023
9824707
Merge branch 'socketio:main' into main
BCCSTeam Nov 25, 2023
de31432
* fix formatting with prettier
BCCSTeam Nov 25, 2023
b43bca0
Merge remote-tracking branch 'origin/main' into main
BCCSTeam Nov 25, 2023
43e5322
* fix returning just the first response on a expected single response
BCCSTeam Nov 27, 2023
082aebd
cleanup
darrachequesne Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/broadcast-operator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap, SocketData>
timedOut = true;
ack.apply(this, [
new Error("operation has timed out"),
this.flags.expectSingleResponse ? null : responses,
this.flags.expectSingleResponse ? responses[0] : responses,
]);
}, this.flags.timeout);

Expand All @@ -252,10 +252,8 @@ export class BroadcastOperator<EmitEvents extends EventsMap, SocketData>
responses.length === expectedClientCount
) {
clearTimeout(timer);
ack.apply(this, [
null,
this.flags.expectSingleResponse ? null : responses,
]);
if (this.flags.expectSingleResponse) ack.apply(this, responses);
BCCSTeam marked this conversation as resolved.
Show resolved Hide resolved
else ack.apply(this, [null, responses]);
}
};

Expand Down