Allow websocket connections behind HAProxy. #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing tests for new data decoding .gitignore
- Progressive data buffering support - Error reporting - Efficient, low memory footprint - Support for the new encoding - Message types - Termination character Tests for decoder Updated utils/utils tests.
… data.js Added .swo to gitignore
Message encoding function + tests Message decoding function started
Fixed message type index for regular messages
_onMessage added as callback to the decoder Added proper message type handling Implemented _onData in the transports
…he new encoding/decoding API Adapted tests
Refactored Client#_payload to make sure the sessionid message (3) is sent Fixed _queue to work with message type and data arguments data#encode was failing to compute length for non-string values. Fixed encode() test utility
Added `tests` utility with common testing globals Refactored htmlfile tests to use the new utilities Refactores websocket tests to use the new utilities Cleaned up flash socket tests
Make sure to test for msg value (index 0) in listener.js decode() callbacks
Deprecated .clientsIndex and clientConnect/clientDisconnect/clientMessage events Added annotations support to broadcast Added Realm class
Added Client#sendJSON method
Make sure to proxy the `realm` method from the Realm to the Listener
Removed monkey-patching in favor of RealmClient class. Prevents race conditions RealmClient Client override added for Realm Fixed Listener#realm Various other fixes
Fixed syntax style in JSONP Polling transport
Fixed flashsocket syntax for 85 columns
Restored previous sessionid generation mechanism temporarily
…rough an HAProxy layer." This reverts commit 606bc70.
|
Applied in 5c9fb03 thanks! |
|
Awesome, thanks!! |
This was referenced Oct 31, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a much cleaner pull request. Sorry about all the noise in the previous one. It was applied against an older version of Socket.IO
This might not be the best way to approach the problem, but it was good enough to get things working for my purposes. The general approach is the one suggested by Willy Tarreau, the author of HAProxy.