Demo using Protocol::HTTP::AcceptEncoding #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
ioquatix
reviewed
Apr 23, 2021
README.md
Outdated
| Async do | ||
| internet = Async::HTTP::Internet.new | ||
| url = "http://httpbin.org/gzip" | ||
| headers = ["accept-encoding", "gzip"] # or {"accept-encoding" => "gzip"} |
There was a problem hiding this comment.
The problem is it should be an Array of Array(key, value).
Similar to {'accept-encoding': 'gzip'}.to_a => [[:"accept-encoding", "gzip"]]
There was a problem hiding this comment.
Ah, of course: fixed in 72ce63b
|
This is ready to go, but I'm not sure if you'll like the documentation style with the two examples combined. Please feel free to suggest changes or of course feel free to tweak as you like! |
|
You don't need to manually add the headers, it will automatically add them: https://github.com/socketry/protocol-http/blob/master/lib/protocol/http/accept_encoding.rb#L48 |
|
Closing since this is entirely automatic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation re: #68
@ioquatix I ran into trouble testing this change -- likely I'm doing something wrong, but I found sending the headers as a hash worked, but as an array did not. I'm hoping you can have a look to see what went wrong, or what I'm doing wrong!
Types of Changes
Testing