Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #15

Merged
merged 1 commit into from Sep 28, 2019
Merged

Update README.md #15

merged 1 commit into from Sep 28, 2019

Conversation

michelboaventura
Copy link

It seems to me the correct method here should be #connect. Using #open always give me:

NoMethodError: undefined method `write' for #<Async::WebSocket::Client:0x000055a219e78d38>

Update README.md
2e3b386 
Call `#connect` instead of `#open`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 118

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.459%
Totals Coverage Status
Change from base Build 117: 0.0%
Covered Lines: 257
Relevant Lines: 281
💛 - Coveralls

@ioquatix ioquatix merged commit 1c4ebb9 into socketry:master Sep 28, 2019
@ioquatix
Copy link
Member

Thanks for catching this and updating the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michelboaventura @coveralls @ioquatix