Prefer Task.stop to be more consistent with Reactor.stop

socketry · Apr 8, 2017 · 9baa101 · 9baa101
1 parent 7605ee8
commit 9baa101
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/async/task.rb b/lib/async/task.rb
@@ -57,8 +57,7 @@ def run
 			return @fiber
 		end
 
-		# TODO: Should this be called `stop!` or `stop`. Is it siginificantly diferent from Reactor#stop that shoud be named differently? Perhaps `interrupt`?
-		def stop!
+		def stop
 			if @fiber.alive?
 				exception = Interrupt.new("Stop right now!")
 				@fiber.resume(exception)

diff --git a/spec/async/task_spec.rb b/spec/async/task_spec.rb
@@ -23,7 +23,7 @@
 RSpec.describe Async::Task do
 	let(:reactor) {Async::Reactor.new}
 
-	describe '#stop!' do
+	describe '#stop' do
 		it "can be stopped" do
 			state = nil
 
@@ -33,7 +33,7 @@
 				state = :finished
 			end
 
-			task.stop!
+			task.stop
 
 			expect(state).to be == :started
 		end