Delegate to Fiber#annotate where possible.
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
fiber-annotations
branch
2 times, most recently
from
aa88f32
to
27147da
Compare
ioquatix
force-pushed
the
fiber-annotations
branch
from
27147da
to
aeb8a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better if fiber annotations were not Async-specific.
I introduced
fiber-annotategem which provides such an interface.This PR uses that interface instead of the internal annotation mechanism where possible. We should eventually deprecate and remove it.
For more context, see https://bugs.ruby-lang.org/issues/19056.
Types of Changes
Contribution