Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all values of a DNS record #76

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CLOUDFLARE_EMAIL='your_cloudlare_email'
CLOUDFLARE_KEY='your_cloudflare_api_key'
CLOUDFLARE_TEST_ZONE_MANAGEMENT=true
12 changes: 9 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ Cloudflare.connect(key: key, email: email) do |connection|
# Add a DNS record. Here we add an A record for `batman.example.com`:
zone = zones.find_by_name("example.com")
zone.dns_records.create('A', 'batman', '1.2.3.4', proxied: false)

# Update a DNS record. Here we update the A record above to be a CNAME record to 'nairobi.kanairo.com'
record = zone.dns_records.find_by_name("example.com") }
record.update(type: "CNAME", name: "nairobi", content: "kanairo.com", proxied: true)


# Get firewall rules:
all_rules = zone.firewall_rules
Expand Down Expand Up @@ -88,9 +93,10 @@ end

1. Fork it
2. Create your feature branch (`git checkout -b my-new-feature`)
3. Commit your changes (`git commit -am 'Add some feature'`)
4. Push to the branch (`git push origin my-new-feature`)
5. Create new Pull Request
3. Run `cp .env.example .env` to create a .env file and populate it with the required environment variables. Edit the new file appropriately
4. Commit your changes (`git commit -am 'Add some feature'`)
5. Push to the branch (`git push origin my-new-feature`)
6. Create new Pull Request

## See Also

Expand Down
2 changes: 2 additions & 0 deletions gems.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@
gem 'simplecov'
gem 'sinatra'
gem 'webmock'
gem 'dotenv'
gem 'pry'
end
11 changes: 11 additions & 0 deletions lib/cloudflare/dns.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,17 @@ def update_content(content, **options)
@value = response.result
end

def update(type: nil, name: nil, content: nil, **options)
response = put(
type: type || @record[:type],
name: name || @record[:name],
content: content || @record[:content],
**options
)

@value = response.result
end

def type
value[:type]
end
Expand Down
27 changes: 25 additions & 2 deletions spec/cloudflare/dns_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
end
end

context "new record" do
describe "#create" do
it "can create dns record" do
@record = zone.dns_records.create("A", subdomain, "1.2.3.4")
expect(@record.type).to be == "A"
Expand All @@ -29,8 +29,9 @@
end
end

context "with existing record" do
describe "#update_content" do
let(:record) {@record = zone.dns_records.create("A", subdomain, "1.2.3.4")}

it "can update dns content" do
record.update_content("4.3.2.1")
expect(record.content).to be == "4.3.2.1"
Expand All @@ -47,4 +48,26 @@
expect(fetched_record.proxied).to be_truthy
end
end

describe "#update" do
let(:subject) { record.update(**new_params)}

let(:record) { @record = zone.dns_records.create("A", "old", "1.2.3.4", proxied: false) }

let(:new_params) do
{
type: "CNAME",
name: "new",
content: "example.com",
proxied: true
}
end

it "can update dns record" do
expect { subject }.to change { record.name }.to("#{new_params[:name]}.#{zone.name}")
.and change { record.type }.to(new_params[:type])
.and change { record.content }.to(new_params[:content])
.and change { record.proxied }.to(new_params[:proxied])
end
end
end
33 changes: 4 additions & 29 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# frozen_string_literal: true

require 'dotenv/load'

AUTH_EMAIL = ENV['CLOUDFLARE_EMAIL']
AUTH_KEY = ENV['CLOUDFLARE_KEY']

Expand All @@ -19,39 +21,12 @@

require 'covered/rspec'
require 'async/rspec'
require 'pry'

require 'cloudflare/rspec/connection'
require 'cloudflare/zones'

RSpec.shared_context Cloudflare::Account do
include_context Cloudflare::RSpec::Connection

let(:account) do
if ACCOUNT_ID
connection.accounts.find_by_id(ACCOUNT_ID)
else
connection.accounts.first
end
end
end

RSpec.shared_context Cloudflare::Zone do
include_context Cloudflare::Account

let(:job_id) {JOB_ID}
let(:names) {NAMES.dup}
let(:name) {ZONE_NAME.dup}

let(:zones) {connection.zones}

let(:zone) {@zone = zones.find_by_name(name) || zones.create(name, account)}

# after do
# if defined? @zone
# @zone.delete
# end
# end
end
Dir[File.expand_path('../support/**/*.rb', __FILE__)].each{|path| require path}

RSpec.configure do |config|
# Enable flags like --only-failures and --next-failure
Expand Down
13 changes: 13 additions & 0 deletions spec/support/cloudflare/account.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# frozen_string_literal: true

RSpec.shared_context Cloudflare::Account do
include_context Cloudflare::RSpec::Connection

let(:account) do
if ACCOUNT_ID
connection.accounts.find_by_id(ACCOUNT_ID)
else
connection.accounts.first
end
end
end
17 changes: 17 additions & 0 deletions spec/support/cloudflare/zone.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# frozen_string_literal: true

RSpec.shared_context Cloudflare::Zone do
include_context Cloudflare::Account

let(:job_id) { JOB_ID }
let(:names) { NAMES.dup }
let(:name) { ZONE_NAME.dup }

let(:zones) { connection.zones }

let(:zone) { @zone = zones.find_by_name(name) || zones.create(name, account) }

after do
@zone.delete if defined? @zone
end
end