Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix tests #8

Merged
merged 4 commits into from
May 27, 2024
Merged

attempt to fix tests #8

merged 4 commits into from
May 27, 2024

Conversation

davidsiaw
Copy link
Contributor

@davidsiaw davidsiaw commented May 27, 2024

This PR attempts to fix the tests to get them to a working state again.

Changes are:

  • comply with new capybara driver syntax
  • remove webdriver gem interfering with chrome download
  • add required async-io gem (probably should be pulled in by falcon?)
  • update ruby min version and removed other gem version restrictions.

Types of Changes

  • Maintenance.

Contribution

@davidsiaw davidsiaw mentioned this pull request May 27, 2024
Closed
3 tasks
@ioquatix
Copy link
Member

async-io is deprecated and should be replaced by io-endpoint - not sure how much we need to fix here.

@davidsiaw
Copy link
Contributor Author

OK I switched async-io out to io-endpoint and it seems to work...? I hope you will forgive me if I seem to be guessing here. I don't know how a lot of this hangs together.

@davidsiaw
Copy link
Contributor Author

upon closer inspection, it seems its only being pulled in but not actually used, so I just got rid of it.

@ioquatix
Copy link
Member

Yes, I just checked it, and I think removal is fine.

@davidsiaw
Copy link
Contributor Author

So it seems we JRuby doesn't like io-event, and TruffleRuby's Fiber has not added your change to implement a different scheduler. Not sure why this shows the checks are unsuccessful when it is marked as experimental.

@ioquatix ioquatix merged commit 455141e into socketry:main May 27, 2024
10 of 12 checks passed
@ioquatix
Copy link
Member

Unfortunately there is a multi-year discussion about that: https://github.com/orgs/community/discussions/15452 and actions/runner#2347 - not sure this will get resolved any time soon, but it's okay and expected.

@ioquatix ioquatix added this to the v1.6.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants