Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide to add load :rack, :supervisor #237

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

adam12
Copy link
Contributor

@adam12 adam12 commented Apr 24, 2024

Types of Changes

  • Maintenance.

Contribution

@ioquatix ioquatix merged commit 8ea5916 into socketry:main Apr 24, 2024
33 of 34 checks passed
@adam12 adam12 deleted the deployment-guides-load-fix branch April 24, 2024 23:01
@ioquatix
Copy link
Member

ioquatix commented Apr 24, 2024

Thanks!

The new service framework makes this approach less important.

However, I'm not sure if we should change the standard documentation at the moment.

In other words, you can write:

# Previous way:
load :rack

rack "myhost" do ...

# Better way:
require "falcon/environment/rack"

service "myhost" do
 include Falcon::Environment::Rack
end

The reason why the latter is better, is because it doesn't require to use falcon host to start, async-service can start it too, and it can be combined with other services, e.g. background job runner, etc.

@adam12
Copy link
Contributor Author

adam12 commented Apr 24, 2024

Ah, interesting! I was just fixing the docs as I encountered them today, but indeed that seems less magical.

@ioquatix
Copy link
Member

My original thinking behind "load ..." was that it would be less "falcon specific". But it turned out not to be useful and probably harmful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants