-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade libev and fix Windows build #32
Conversation
This version have some improvements for Windows. Made manual update and verified patches (hacks) still apply.
These are present in POSIX OS, not Windows, so we avoid enabling such functionality.
Upgrade libev and fix Windows build
Thank you so much! You rock! 😺 |
Nice! |
Could we get a new version released? |
Soon! ;) Tony Arcieri On Aug 1, 2013, at 1:31 PM, "Michael D. Ivey" notifications@github.com Could we get a new version released? — |
nio4r 0.5.0 has been released! /cc @ivey |
Whoa!! |
@luislavena Hi, I'm using Reel for a WebSocket server. And i found an issue same as guard/guard-livereload#69 :
Seems like it just happens in Windows and Ruby 2.0, Is there any solutions to pass it? |
@SaitoWu lame! That is most likely an issue with https://github.com/tmm1/http_parser.rb |
@SaitoWu the http_parser.rb gem needs to be cross-compiled to include Ruby 2.0 binaries. This can be avoided by simply uninstalling that gem and installing it again with |
One could use an alternative ffi version of http_parser: https://github.com/cotag/http-parser |
@stakach the nice thing about the current library is it has a pure-Java JRuby version that exposes the same API |
Hello,
This pull request upgrades libev to version 4.15 and adjust the defines requires for Windows compilation.
Before this patch, it was not possible to build nio4r, with it, build succeed and spec pass, except for the following two:
These two failures seems related to a bug I reported to Ruby-Core a year ago:
https://bugs.ruby-lang.org/issues/5954
And this only happens with
IO.pipe
. Pipes should work transparently on Windows, but is clear that whatIO.pipe
is doing is not creating a compatible file descriptor forread_nonblock
and requires further investigation.This pull request should solve Issue #31
Cheers! ❤️ ❤️ ❤️