Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support 2.3 on CI #2

Merged
merged 2 commits into from
Jul 9, 2019
Merged

support 2.3 on CI #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b73c403
support 2.3 on CI
ganmacs Jun 20, 2019
97a3690
Add monkey patch which provide String#unpack1 for ruby 2.3
ganmacs Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ cache: bundler

matrix:
include:
- rvm: 2.3
- rvm: 2.4
- rvm: 2.5
- rvm: 2.6
Expand Down
1 change: 1 addition & 0 deletions lib/protocol/http2/frame.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
# THE SOFTWARE.

require_relative 'error'
require_relative 'monkey_patch'

module Protocol
module HTTP2
Expand Down
10 changes: 10 additions & 0 deletions lib/protocol/http2/monkey_patch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
begin
''.unpack1('*')
rescue => NoMethodError
# for compat ruby 2.3
class String
def unpack1(template)
unpack(template).first
end
end
end