Fix length when reading websocket frame #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, can you add a spec for it too? Thanks! |
|
Sure, I'll have something later today. |
Per https://tools.ietf.org/html/rfc6455 page 29: > If 127, the following 8 bytes interpreted as a 64-bit unsigned integer I've verified that changing the 4 to an 8 makes this gem work locally. Otherwise it raises `protocol-websocket-0.7.2/lib/protocol/websocket/frame.rb:154:in `read': undefined method `>' for nil:NilClass (NoMethodError)`
Without the fix in the previous commit, this spec will fail:
Protocol::WebSocket::Connection
message length
can handle large message (>65k) (FAILED - 1)
Failures:
1) Protocol::WebSocket::Connection message length can handle large message (>65k)
Failure/Error: if length > maximum_frame_size
NoMethodError:
undefined method `>' for nil:NilClass
|
Added a spec. Let me know if that works for you |
|
Excellent work! Thanks so much for this. |
|
Released in v0.7.3. What are you planning to use this library for? |
|
Thanks for the quick release! I had it locally patched in the meanwhile. |
|
What is home-assistant? |
|
https://www.home-assistant.io/ |
|
Looks great! Well if you find any other issues your contributions are welcome! |
|
Thanks, I'll definitely send any other bugfixes/improvements your way, especially since the review was very quick :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://tools.ietf.org/html/rfc6455 page 29:
I've verified that changing the 4 to an 8 makes this gem work locally. Otherwise it raises
protocol-websocket-0.7.2/lib/protocol/websocket/frame.rb:154:in `read': undefined method `>' for nil:NilClass (NoMethodError)