Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TruffleRuby support #29

Closed
deepj opened this issue Mar 18, 2019 · 7 comments
Closed

TruffleRuby support #29

deepj opened this issue Mar 18, 2019 · 7 comments

Comments

@deepj
Copy link

deepj commented Mar 18, 2019

Probably it means to remove hitimes dependency due to oracle/truffleruby#1436

@ioquatix
Copy link
Member

I believe you can replace hitimes with timers gem. It no longer depends on hitimes. Please feel free to submit a PR.

@shayneoneill
Copy link

Was this ever fixed?

@ioquatix
Copy link
Member

No I don't believe so. This particular gem is not under active development either.

@havenwood
Copy link
Member

@shayneoneill The hitimes maintainer worked with TruffleRuby maintainers to prepare a patch that removes the C and Java dependencies now that a pure Ruby implementation is possible. It hasn't been merged: copiousfreetime/hitimes#73

@shayneoneill
Copy link

shayneoneill commented Aug 28, 2019

I managed to fork myself a copy of this and just remove the hitimes and it worked.

And yeah with the unmaintained dependency. Seems to be the way of things. Poor old rubys undergoing pretty savage bit-rot right now in its ecosystem. The "everything must be javascript" cargo cult has been brutal on rails and unfortunately ruby was a bit too dependent on rails being its killer app

@ioquatix
Copy link
Member

Feel free to submit a PR. That would be great.

@copiousfreetime
Copy link

Just an FYI - hitimes is quite stable and maintained - no need for any new features just bug fixes and compatibility issues as the ecosystem evolves.

I was waiting on feedback from truffleruby the pull request I sent them (oracle/truffleruby#1594) to allow hitimes to run on truffleruby without a c extension. Apparently that was done in march and I missed the notification. @eregon pinged today to remind me that hitimes was good to go on truffle ruby.

hitimes 2.0.0 is pushed and released, use if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants