Skip to content

Commit

Permalink
Prefer Traces.trace.
Browse files Browse the repository at this point in the history
  • Loading branch information
ioquatix committed Jun 19, 2023
1 parent e024952 commit 929957b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions test/traces/backend/datadog.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ def my_method(argument)

Traces::Provider(MyClass) do
def my_method(argument)
trace('my_method', attributes: {argument: argument}) {super}
Traces.trace('my_method', attributes: {argument: argument}) {super}
end

def my_span
trace('my_span') {|span| return span}
Traces.trace('my_span') {|span| return span}
end

def my_context
trace('my_context') {|span| return self.trace_context}
Traces.trace('my_context') {|span| return Traces.trace_context}
end

def my_span_and_context
trace('my_span_and_context') {|span| return span, self.trace_context}
Traces.trace('my_span_and_context') {|span| return span, Traces.trace_context}
end
end

Expand All @@ -37,7 +37,7 @@ def my_span_and_context
end

it "can invoke trace wrapper" do
expect(instance).to receive(:trace)
expect(Traces).to receive(:trace)

instance.my_method(10)
end
Expand Down Expand Up @@ -73,7 +73,7 @@ def my_span_and_context

describe '#trace_context=' do
it "can update trace context" do
instance.trace_context = context
Traces.trace_context = context

span = instance.my_span

Expand All @@ -86,7 +86,7 @@ def my_span_and_context
it "can round-trip trace context" do
parsed_context = Traces::Context.parse(context.to_s)

instance.trace_context = parsed_context
Traces.trace_context = parsed_context

span = instance.my_span

Expand Down
2 changes: 1 addition & 1 deletion traces-backend-datadog.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ Gem::Specification.new do |spec|
spec.files = Dir.glob(['{lib}/**/*', '*.md'], File::FNM_DOTMATCH, base: __dir__)

spec.add_dependency "ddtrace", "~> 1.2"
spec.add_dependency "traces", "~> 0.6"
spec.add_dependency "traces", "~> 0.10"
end

0 comments on commit 929957b

Please sign in to comment.