New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack Client Assets doesn't import css files #312
Comments
Hi there Does this work correctly when in development? If so this is clearly a bug and I will try to fix. |
packAssets doesn't pack css import dependencies into one file when in development the css import files are usually served from /_serveDev/css/libs/style.css but in production it try to fetch it from /assets/libs/style.css and it would as normally return a 404 error unless one copies the file into /assets/ directory so i believe this needs to be fixed. |
Agreed. We should have 100% the same behaviour between dev and prod modes. If you fancy looking into this and submitting a pull request, that would be fantastic. Otherwise I'll add it to the todo list and look at it after RealtimeConf |
Adding this into 0.3.12 |
I think it is important to ensure that you can still explicitly have @import statements in the compiled CSS if that is what you really want to do. LESS and SASS formatters make the distinction, so it's important that this is a formatter responsibility not one in the bundler. The simplest solution is to have a CSS Import Combining formatter. |
The relative URL of assets now work the same in development and production in version 0.4 If you want to resolve @import statements in CSS you can make a custom bundler that does it for you. So to me this is fixed. |
I've noticed pack client assets doesn't import css files for example if i had
@import 'libs/style.css'
@import 'libs/custom.css'
@import 'libs/font-awesome/font-awesome.css'
it doesn't import t
The text was updated successfully, but these errors were encountered: