Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pack Client Assets doesn't import css files #312

Closed
hackable opened this Issue Oct 15, 2012 · 6 comments

Comments

Projects
None yet
4 participants

I've noticed pack client assets doesn't import css files for example if i had

@import 'libs/style.css'
@import 'libs/custom.css'
@import 'libs/font-awesome/font-awesome.css'

it doesn't import t

owenb commented Oct 18, 2012

Hi there

Does this work correctly when in development? If so this is clearly a bug and I will try to fix.

packAssets doesn't pack css import dependencies into one file when in development the css import files are usually served from /_serveDev/css/libs/style.css but in production it try to fetch it from /assets/libs/style.css and it would as normally return a 404 error unless one copies the file into /assets/ directory so i believe this needs to be fixed.

owenb commented Oct 21, 2012

Agreed. We should have 100% the same behaviour between dev and prod modes.

If you fancy looking into this and submitting a pull request, that would be fantastic. Otherwise I'll add it to the todo list and look at it after RealtimeConf

Contributor

paulbjensen commented Feb 1, 2015

Adding this into 0.3.12

@paulbjensen paulbjensen self-assigned this Feb 1, 2015

@paulbjensen paulbjensen added this to the 0.3.12 milestone Feb 1, 2015

Owner

thepian commented Feb 22, 2015

I think it is important to ensure that you can still explicitly have @import statements in the compiled CSS if that is what you really want to do.

LESS and SASS formatters make the distinction, so it's important that this is a formatter responsibility not one in the bundler.

The simplest solution is to have a CSS Import Combining formatter.

Owner

thepian commented Mar 11, 2015

The relative URL of assets now work the same in development and production in version 0.4

If you want to resolve @import statements in CSS you can make a custom bundler that does it for you.

So to me this is fixed.

@thepian thepian closed this Mar 11, 2015

@thepian thepian modified the milestones: 0.4, 0.3.12 Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment