Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Fix premature usage of __ipc primordial in 'ipc.js' #62

Closed
jwerle opened this issue Jan 4, 2023 · 0 comments · Fixed by #63
Closed

Fix premature usage of __ipc primordial in 'ipc.js' #62

jwerle opened this issue Jan 4, 2023 · 0 comments · Fixed by #63
Assignees
Labels
bug Something isn't working

Comments

@jwerle
Copy link
Member

jwerle commented Jan 4, 2023

Here: https://github.com/socketsupply/io/blob/master/ipc.js#L47

export const postMessage = window.__ipc.postMessage

Technically, injected primordials SHOULD exist before any user space script runs, but this is not true for Android because of when and how we inject the runtime preload VM script at page load.

@jwerle jwerle added the bug Something isn't working label Jan 4, 2023
@jwerle jwerle self-assigned this Jan 4, 2023
@jwerle jwerle changed the title Fix usage of premature usage of __ipc primordial in 'ipc.js' Fix premature usage of __ipc primordial in 'ipc.js' Jan 4, 2023
jwerle added a commit that referenced this issue Jan 4, 2023
- Fixes #62: Fix premature usage of __ipc primordial in 'ipc.js'

Technically, injected primordials SHOULD exist before any user space
script runs, but this is not true for Android because of when and how we
inject the runtime preload VM script at page load.
@jwerle jwerle closed this as completed in #63 Jan 5, 2023
jwerle added a commit that referenced this issue Jan 5, 2023
- Fixes #62: Fix premature usage of __ipc primordial in 'ipc.js'

Technically, injected primordials SHOULD exist before any user space
script runs, but this is not true for Android because of when and how we
inject the runtime preload VM script at page load.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant