Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.ps1 / libuv build/config output behaviour #138

Closed
mribbons opened this issue Feb 2, 2023 · 1 comment
Closed

install.ps1 / libuv build/config output behaviour #138

mribbons opened this issue Feb 2, 2023 · 1 comment

Comments

@mribbons
Copy link
Contributor

mribbons commented Feb 2, 2023

install.ps1 has been reverted as per:
abade8b

The now reverted change which removed $LIBUV_BUILD_TYPE from the Copy-Item commands was due to the fact that I observed libuv building directly to $WORKING_BUILD_PATH\libuv\build on two separate Windows systems.

I have done some investigation and can't see how the cmake --config switch does anything other than govern which config is used for build, it does not influence the output folder.

https://cmake.org/cmake/help/latest/manual/cmake.1.html:

--config <cfg>
For multi-configuration tools, choose configuration <cfg>.

Testing has been performed against libuv 1.44.2 (tag) and 1.x (branch).

cmake --version
cmake version 3.13.4

clang --version
clang version 15.0.1
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\Llvm\x64\bin

Note that with the now reverted code, install.ps1 operates as follows on my workstation:

ok - built libuv
Copy-Item : Cannot find path 'D:\code\socket\socket\build\libuv\build\Release\uv_a.lib' because it does not exist.
At D:\code\socket\socket\bin\install.ps1:49 char:3
+   Copy-Item "$WORKING_BUILD_PATH\libuv\build\$LIBUV_BUILD_TYPE\uv_a.l ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (D:\code\socket\...elease\uv_a.lib:String) [Copy-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.CopyItemCommand

@trevnorris Can your versions and we can start comparing from there...

@mribbons
Copy link
Contributor Author

mribbons commented Feb 4, 2023

Resolved by #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant