Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build is broken #144

Closed
chicoxyzzy opened this issue Feb 4, 2023 · 4 comments
Closed

Windows build is broken #144

chicoxyzzy opened this issue Feb 4, 2023 · 4 comments
Assignees
@jwerle
Labels
bug Something isn't working build An issue, discussion, or pull request related to building the source windows

Comments

@chicoxyzzy
Copy link
Member

This commit broke the Windows CI 00e2e6d

https://github.com/socketsupply/socket/actions/runs/4063245908/jobs/6995257824

cc @jwerle @mribbons
@chicoxyzzy chicoxyzzy added bug Something isn't working windows build An issue, discussion, or pull request related to building the source labels Feb 4, 2023
@chicoxyzzy
Copy link
Member Author

related issue #139

@mribbons
Copy link
Contributor

mribbons commented Feb 4, 2023

Resolved by #146

@mribbons
Copy link
Contributor

mribbons commented Feb 4, 2023

@chicoxyzzy #139 relates to android only,
#138 definitely relates to this ticket.

@chicoxyzzy
Copy link
Member Author

Fixed in #146. Thank you Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwerle jwerle

Labels
bug Something isn't working build An issue, discussion, or pull request related to building the source windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwerle @chicoxyzzy @mribbons