Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android / install.ps1 - Ensure libuv src copied to correct folders #139

Closed
mribbons opened this issue Feb 2, 2023 · 2 comments
Closed

Comments

@mribbons
Copy link
Contributor

mribbons commented Feb 2, 2023

As part of resolving android build for windows, I resolved an issue where libuv src wasn't copied to SOCKET_HOME in order to be available for Android NDK build.
This resulted in a silent drop out of ssc.exe during npm build.
I resolved the issue:
00e2e6d

The change has been reverted as part of a separate libuv issue, this single line can be undone without affecting windows build:
abade8b#diff-e9a96fb537f64b60e955f6d260d0d3c697cb45050752cf4d834833486b4d8530L88

-   Copy-Item -Path "$WORKING_BUILD_PATH\libuv\src" -Destination "$ASSET_PATH\uv\src" -Recurse -Force
@chicoxyzzy
Copy link
Member

was it fixed?

@jwerle
Copy link
Member

jwerle commented Mar 24, 2023

yep

@jwerle jwerle closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants