host and port are ignored for the desktop builds

[chicoxyzzy]

We only pass these two values when run on iOS or Android, but they should work for desktop builds as well

[m4gicpotato]

Hello there. I'm looking to run Nuxt.JS local web server with hot reloading for development purposes and then automatically make a static build when I build the app. I think this issue should get more attention since this is critical for development environments and a total blocker for my working environment for example.

Somehow this piece of code is not properly working:

socket/src/desktop/main.cc

Line 901 in a96824c

if (_port > 0) {

[lamiazar]

Moved to in progress will close it after the new release.

[chicoxyzzy]

@lamiazar let's keep it in TODO until someone will pick it

[nnnnathann]

Hi!

After some experimentation with the project, I was able to get the dev server URL working on mac desktop with a few changes to cli.cc and main.cc:

diff --git a/src/cli/cli.cc b/src/cli/cli.cc
index 88fce1d5..30ed1ebd 100644
--- a/src/cli/cli.cc
+++ b/src/cli/cli.cc
@@ -2150,7 +2150,7 @@ int main (const int argc, const char* argv[]) {
     settings.insert(std::make_pair("host", devHost));
 
     String devPort = "0";
-    if (optionsWithValue.count("port") > 0) {
+    if (optionsWithValue.count("--port") > 0) {
       devPort = optionsWithValue["--port"];
     }
     settings.insert(std::make_pair("port", devPort));
diff --git a/src/desktop/main.cc b/src/desktop/main.cc
index 1a46db82..b4b25491 100644
--- a/src/desktop/main.cc
+++ b/src/desktop/main.cc
@@ -67,7 +67,7 @@ MAIN {
   static App* app_ptr = &app;
 
   app.setWindowManager(&windowManager);
-  constexpr auto _port = PORT;
+  const auto _port = getDevPort();
 
   const SSC::String OK_STATE = "0";
   const SSC::String ERROR_STATE = "1";

Apologies for not submitting a full PR, I feel a little worried about the impact of the changes (didn't fully examine the impact).

Happy to help wherever I can,
nathan

[jwerle]

Hi!

After some experimentation with the project, I was able to get the dev server URL working on mac desktop with a few changes to cli.cc and main.cc:

diff --git a/src/cli/cli.cc b/src/cli/cli.cc
index 88fce1d5..30ed1ebd 100644
--- a/src/cli/cli.cc
+++ b/src/cli/cli.cc
@@ -2150,7 +2150,7 @@ int main (const int argc, const char* argv[]) {
     settings.insert(std::make_pair("host", devHost));
 
     String devPort = "0";
-    if (optionsWithValue.count("port") > 0) {
+    if (optionsWithValue.count("--port") > 0) {
       devPort = optionsWithValue["--port"];
     }
     settings.insert(std::make_pair("port", devPort));
diff --git a/src/desktop/main.cc b/src/desktop/main.cc
index 1a46db82..b4b25491 100644
--- a/src/desktop/main.cc
+++ b/src/desktop/main.cc
@@ -67,7 +67,7 @@ MAIN {
   static App* app_ptr = &app;
 
   app.setWindowManager(&windowManager);
-  constexpr auto _port = PORT;
+  const auto _port = getDevPort();
 
   const SSC::String OK_STATE = "0";
   const SSC::String ERROR_STATE = "1";

Apologies for not submitting a full PR, I feel a little worried about the impact of the changes (didn't fully examine the impact).

Happy to help wherever I can,
nathan

Hi @nnnnathann,

We'd happily review a PR if you could make one

[nnnnathann]

Sure, no problem. Created one over here: #565

[lamiazar]

Fixed by #565

[chicoxyzzy]

@davidmyersdev paths like /path/to/asset.css should work in v0.4.0 that we just published. Please try it and create a new issue if you need any help!

[davidmyersdev]

I finally had a chance to test this again, and I can confirm it works as expected now! Thanks so much!