Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: ssc init should warn when run on a non-empty directory #51

Closed
WesSouza opened this issue Dec 12, 2022 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@WesSouza
Copy link

I ran ssc init without realizing it would put files in the current directory (and ask for a project name like many other init commands do).

Running it in a folder with contents should ask the user before creating files.

@chicoxyzzy chicoxyzzy added the enhancement New feature or request label Dec 14, 2022
@chicoxyzzy chicoxyzzy self-assigned this Dec 14, 2022
@chicoxyzzy
Copy link
Member

@heapwolf I remember you was opposed to make ssc accept user input, but I think this case makes sense.

@WesSouza
Copy link
Author

@chicoxyzzy it could also fail and require a flag like --force.

@heapwolf
Copy link
Member

heapwolf commented Dec 19, 2022

Yeah I prefer it to fail with Directory not empty. Refusing to init. To override use --force flag. , +1 on --force, PR welcome!

@chicoxyzzy chicoxyzzy added the good first issue Good for newcomers label Dec 19, 2022
@iamfotx
Copy link

iamfotx commented Jan 3, 2023

Hi, @chicoxyzzy & @heapwolf I'd love to take this one, can do it over the weekend if that's fine?

@chicoxyzzy
Copy link
Member

This was fixed in #239 in a bit different way. ssc init warns instead of trying to replace files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants