Add --config option to the ssc init #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also going to implement this one here #51 |
|
Maybe it's worthwhile just checking if files exist before over writing them? |
|
I agree with @jwerle here. I think the creation of the directory and files is helpful but should be guarded on whether they don't yet exist, rather than either a potential error OR (worse) overwriting them. |
chicoxyzzy
force-pushed
the
cli_init_config_only
branch
from
ac7323b
to
6103874
Compare
chicoxyzzy
commented
Mar 14, 2023
| @@ -960,7 +960,7 @@ int main (const int argc, const char* argv[]) { | |||
| } | |||
|
|
|||
| // default values | |||
| settings["build_output"] = settings["build_output"].size() > 0 ? settings["build_output"] : "dist"; | |||
| settings["build_output"] = settings["build_output"].size() > 0 ? settings["build_output"] : "build"; | |||
There was a problem hiding this comment.
so now we have "build" by default in both .gitignore and as an implicit default value
|
made it exit early when |
jwerle
approved these changes
Mar 14, 2023
chicoxyzzy
force-pushed
the
cli_init_config_only
branch
from
d6e5033
to
34b7cc6
Compare
chicoxyzzy
force-pushed
the
cli_init_config_only
branch
from
34b7cc6
to
771afdb
Compare
jwerle
reviewed
Mar 14, 2023
| input = "src" | ||
|
|
||
| ; The name of the program and executable to be output. Can't contain spaces or special characters. Required field. | ||
| name = "beepboop" | ||
|
|
||
| ; The binary output path. It's recommended to add this path to .gitignore. | ||
| output = "dist" | ||
| output = "build" |
jwerle
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to wrap the existing application into Socket Runtime