Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] URLs return 'null' as the origin when using 'socket:' protocol #893

Closed
wittjosiah opened this issue Jan 12, 2024 · 0 comments · Fixed by #896
Closed

[bug] URLs return 'null' as the origin when using 'socket:' protocol #893

wittjosiah opened this issue Jan 12, 2024 · 0 comments · Fixed by #896
Assignees
Labels
api An issue, task, or discussion related to public runtime APIs bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript

Comments

@wittjosiah
Copy link

What OS are you using (uname -a, or Windows version)?

Darwin jdw-mbp.local 23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:54:05 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6031 arm64

What version Socket Runtime are you using?

0.5.4 (97fa3f7c)

What did you expect to see and what you saw instead?

new URL('./example.html', 'socket://com.my-app').origin returns the string 'null' but I would expect it to return 'socket://com-my-app'.

@jwerle jwerle self-assigned this Jan 15, 2024
@jwerle jwerle added bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An issue, task, or discussion related to public runtime APIs bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants