Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api/url/index.js): fix how URL origin is determined #896

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(api/url/index.js): fix how URL origin is determined #896

merged 1 commit into from
Jan 15, 2024

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Jan 15, 2024

Fixes #893

@jwerle jwerle added bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs labels Jan 15, 2024
@jwerle jwerle requested a review from heapwolf January 15, 2024 17:41
@jwerle jwerle self-assigned this Jan 15, 2024
@jwerle jwerle merged commit 415d825 into master Jan 15, 2024
3 of 7 checks passed
@jwerle jwerle deleted the fix-url-origin branch January 15, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heapwolf heapwolf heapwolf approved these changes

Assignees

@jwerle jwerle

Labels
api An issue, task, or discussion related to public runtime APIs bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] URLs return 'null' as the origin when using 'socket:' protocol
2 participants
@jwerle @heapwolf