Macos (Android) CI: Incorporate Android FTE #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop out straight away when valid javac found
Not required, existing exports are added to search paths in get_android_default_search_paths
Rather than automatically defaulting to it if no other java is found.
android BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 64
+ fix bad inline `; exit 1` calls, these don't work.
The cache became corrupted The cache doesn't seem any faster than reactivecircus/android-emulator-runner@v2 by itself
This allows us to test outside CI more reliably, rather than relying on github actions Implemented timeout / watchdog setup to handle app failures that aren't caught by main adb loop in poll-adb-logcat.sh
+ use swift shader option in CI
(emulator / -gpu swiftshader_indirect support)
mribbons
force-pushed
the
macos-android-ci-perf
branch
from
2fb6f18
to
6206d9c
Compare
chicoxyzzy
reviewed
Apr 26, 2023
(Testing without empty variables)
mribbons
force-pushed
the
macos-android-ci-perf
branch
from
dd01010
to
1cb8b5f
Compare
jwerle
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that CI is currently failing due to a
commonjsissue. This is proof that this CI setup does work.Note that #354 should be merged first, and ASAP.
switch to using test-android-emulator
This allows us to test outside CI more reliably, rather than relying
on github actions
Implemented timeout / watchdog setup to handle app failures
that aren't caught by main adb loop in poll-adb-logcat.sh
macos android ci: Don't use avd cache
"The cache became corrupted"
The cache doesn't seem any faster than just firing up a clean AVD image
fix jniLibs not building when flagRunUserBuildOnly set (CI wasn't testing this before, libsocket-runtime.so wasn't being deployed with the app)
implement app start timeout and error output to catch failed app starts, which in turn prevents CI hanging because it would never receive a signal from webview js
dont search /Applications for java, this is extremely slow under CI
require exact java version
android BUG! exception in phase 'semantic analysis' in source unit 'BuildScript' Unsupported class file major version 64
only build x86_64 - performance
determine_cxx: fix CXX not persisted to .ssc.env