Set monitor default geometry on Linux #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
added
bug
chicoxyzzy
approved these changes
Apr 28, 2023
chicoxyzzy
reviewed
Apr 28, 2023
Comment on lines
+7
to
+8
| #define DEFAULT_MONITOR_WIDTH 720 | ||
| #define DEFAULT_MONITOR_HEIGHT 364 |
There was a problem hiding this comment.
actually we should take these values from windowManager's options.default{Width|height}
There was a problem hiding this comment.
That won't work if [window] height = 50% is set
There was a problem hiding this comment.
What was the issue with percents? I don't remember. all values should be in pixels in the end
There was a problem hiding this comment.
String defaultWidth = app.appData["window_width"].size() > 0 ? app.appData["window_width"] : "100%";We also don't have access to the WindowManager in the Window class.
|
|
lamiazar
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#363