Android app start fix #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't wait for emulator to boot.
lamiazar
approved these changes
Jun 1, 2023
jwerle
approved these changes
Jun 1, 2023
chicoxyzzy
reviewed
Jun 1, 2023
| @@ -2110,6 +2127,7 @@ int main (const int argc, const char* argv[]) { | |||
| auto cnt = 0; | |||
|
|
|||
| AndroidCliState androidState; | |||
| androidState.targetPlatform = targetPlatform; | |||
There was a problem hiding this comment.
you may need to do the same for ssc run command
There was a problem hiding this comment.
maybe we can move the androidState populating to the run function?
There was a problem hiding this comment.
Good catch, thanks 😅
maybe we can move the androidState populating to the run function?
Let's slate this for the next release so we can test it a bit more?
Just to confirm, does run get called by build?
It might be better to have a platformInit() that in turn calls platform specific setup.
AndroidState should eventually contain everything necessary for build, currently it only covers run.
There was a problem hiding this comment.
Just to confirm, does run get called by build?
yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli: android: fail immediately if adb fails to install to device
Don't wait for emulator to boot.